Add out method

[marimeireles]

No description provided.

[marimeireles]

This is a WIP! I'd appreciate your input @JohanMabille :)

[martinRenou]

@marimeireles could you provide more context concerning this PR?

[marimeireles]

I think this is more how you imagined it @JohanMabille?
If yes I'm gonna write some tests for it.

[martinRenou]

Why do you have an extra data argument to this function? Shouldn't this be enough?

nl::json create_successful_reply(const nl::json& payload,
                                 const nl::json& user_expressions)

[martinRenou]

I believe code is not part of the specs for the complete_reply https://jupyter-client.readthedocs.io/en/latest/messaging.html#completion

[martinRenou]

Looks good!

[JohanMabille]

You may want to move the payload to avoid costly copy.

[marimeireles]

I haven't finished it yet!
I'm working on some tests. I added other helper functions.

[marimeireles]

so, this is the output I get:

(xeus) mariana@wintermute ~/dev/xeus/build/test (output*?) $ ./test_unit_kernel
[doctest] doctest version is "2.4.6"
[doctest] run with "--help" for options
this print is running 4 ever...

After running the following code:

        TEST_CASE("print_starting_message")
        {
            auto context = make_context<zmq::context_t>();

            using interpreter_ptr = std::unique_ptr<test_kernel::test_interpreter>;
            interpreter_ptr interpreter = interpreter_ptr(new test_kernel::test_interpreter());
            xkernel kernel(get_user_name(),
                         std::move(context),
                         std::move(interpreter),
                         make_xserver_zmq);
            std::string kernel_config = print_starting_message(kernel.get_config());
            bool found = kernel_config.find(" Starting kernel...\n"
                                            "\n"
                                            "If you want to connect to this kernel from an other client, just copy and paste the following content inside of a `kernel.json` file. And then run for example:\n"
                                            "\n"
                                            "# jupyter console --existing kernel.json\n"
                                            "\n"
                                            "kernel.json\n"
                                            "```\n"
                                            "{\n"
                                            "    \"transport\": \"tcp\",\n");
            std::cout << "this print is running 4 ever..." << std::endl;
            REQUIRE_EQ(found, true);
        }

    TEST_CASE("extract_filename")
    {
        std::cout << "the extract_filename is never starting bc of the other test" << std::endl;
        char** argv = new char*;
        argv[0] = (char*)"-f";
        argv[1] = (char*)"connection.json";
        std::string file_name = extract_filename(3, argv);
        REQUIRE_EQ(file_name, "connection.json");
    }

is just stuck in the first test, @JohanMabille

[marimeireles]

It was supposed to print the next thing on the next test: std::cout << "the extract_filename is never starting bc of the other test" << std::endl;