Skip to content
This repository has been archived by the owner on Dec 29, 2017. It is now read-only.

add modules to PYTHONPATH before starting kernels #47

Closed
wants to merge 1 commit into from
Closed

add modules to PYTHONPATH before starting kernels #47

wants to merge 1 commit into from

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 7, 2014

In the interest of making colaboratory a proper Python package,
it may make sense to move the utilities into the colaboratory/ directory,
which would make them importable without modifying the path.

closes #34

@KesterTong
Copy link
Contributor

Thanks Min. We would prefer the add colabtools to the path, because our internal users are already using import colabtools.

@minrk
Copy link
Member Author

minrk commented Jul 7, 2014

Do you plan to put many things in /modules? This seems an odd behavior. If you put colabtools in the top-level dir, you wouldn't need to touch the path.

@KesterTong
Copy link
Contributor

good point. We had originally thought of adding a modules directory to package extra modules with the colab installation. Given the current structure, that makes a lot less sense. So I'm fine with your idea of adding colabtools to the top level directory. Will do that instead of merging this PR.

@KesterTong KesterTong closed this Jul 7, 2014
@minrk
Copy link
Member Author

minrk commented Jul 7, 2014

Sounds good. Then later, colaboratory and colabtools can be proper installable Python packages.

@minrk minrk deleted the colabtools branch July 7, 2014 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "colabtools" library to git repo
2 participants