Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Double leading slash on git URLs for example Deploy As #21

Closed
parente opened this issue Oct 1, 2015 · 1 comment
Closed

Double leading slash on git URLs for example Deploy As #21

parente opened this issue Oct 1, 2015 · 1 comment
Labels
bug

Comments

@parente
Copy link
Member

parente commented Oct 1, 2015

https://github.com/jupyter-incubator/dashboards/blob/master/urth/dashboard/nbexts/bundle_handler.py#L159

jupyter_server already has the base_url on the end of it. Adding it here produces an incorrect URL.
@parente parente added the bug label Oct 1, 2015
@parente
Copy link
Member Author

parente commented Oct 1, 2015

I'll take this one.

parente added a commit to parente/dashboards that referenced this issue Oct 2, 2015
@parente
Add base url only once on deploy
6430256 
Fixes jupyter#21

(c) Copyright IBM Corp. 2015
@parente parente mentioned this issue Oct 2, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parente