Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[issue 14]: Initial prototype of sentiment dashboard #37

Merged
merged 3 commits into from
Oct 21, 2015
Merged

[issue 14]: Initial prototype of sentiment dashboard #37

merged 3 commits into from
Oct 21, 2015

Conversation

Lull3rSkat3r
Copy link
Member

Creates a dashboard for analyzing community sentiment around open source projects.

@Lull3rSkat3r
Copy link
Member Author

Still need to add streaming. I will update when streaming is included.

@parente
Copy link
Member

parente commented Oct 20, 2015

Need a title at the top and a couple sentence summary of what it does for notebook mode. I know the text for the UI is in there, but it's wayyyyyy down.

In cell #2:

./static/ is no longer correct. Check what all the other notebooks are doing to account for the change in widgets.

In cell #8:

IndentationError: unindent does not match any outer indentation level

Make a comment on the terrible time.sleep hack. Point to a widgets issue about it if possible.

When clicking "Collect Data", nothing happens and I get Uncaught TypeError: get_individual_sentiment_data.invoke is not a function in the JS console.

@parente
Copy link
Member

parente commented Oct 20, 2015

Extra blank bullet under "Positive" header.

@parente
Copy link
Member

parente commented Oct 20, 2015

And you may have pushed your private GitHub key.

@Lull3rSkat3r
Copy link
Member Author

The only thing I am not able to fix is the Uncaught TypeError: get_individual_sentiment_data.invoke is not a function. If I run all the cells in notebook view, or dashboard view everything is fine. The only time I encounter an error is when I switch between the two. The specific steps to reproduce are:

  1. Running all the cells in the notebook view
  2. Switching to Dashboard view
  3. Filling out the form for org/repo and clicking Collect Data

There is a branch that needs to be merged into declarativewidgets for the historical urth-viz-chart to work correctly with the dates. I will get with @peller to see about merging his branch.

I am now seeing problems with channel not being defined client side. Looking into that now.

@parente
Copy link
Member

parente commented Oct 20, 2015

So having the thing go missing between switch to layout and dashboard view is odd. Do you see an re-init messages in the console? AFAIK, there's no add/remove of DOM nodes so things shouldn't go missing.

/cc @lbustelo @jhpedemonte

@Lull3rSkat3r
Copy link
Member Author

So after switching views I looked at the value for get_total_sentiment_data and get_individual_sentiment_data. They have been changed into arrays of dom elements ⊙_ʘ. Trying to figure out where that change is coming from.
screen shot 2015-10-20 at 8 56 48 am

@Lull3rSkat3r
Copy link
Member Author

Figured out my channel issue. Moved some code around and didn't have enough ☕ to realize I moved python code into a <script> tag.

@parente
Copy link
Member

parente commented Oct 20, 2015

🎱

@parente
Copy link
Member

parente commented Oct 20, 2015

Remaining issues that need to be fixed before we can merge this:

  1. Why does Handle formatting of different types in chart declarativewidgets#36 cause path issues? We need it to make the historical plot widget work properly.
  2. Why does running in notebook view then switching to dashboard view cause this weirdness: [issue 14]: Initial prototype of sentiment dashboard #37 (comment)

@parente
Copy link
Member

parente commented Oct 21, 2015

I tested with jupyter/declarativewidgets#53 and seems to work. I've got a few nits of things to fix in the next PR that I'll put in the issue.

Waiting for jupyter/declarativewidgets#53 to merge so this will work properly when it goes in.

(c) Copyright IBM Corp. 2015
@lbustelo
Copy link
Contributor

jupyter/declarativewidgets#53 is merged

@parente
Copy link
Member

parente commented Oct 21, 2015

:shipit:

parente added a commit that referenced this pull request Oct 21, 2015
…-notebook

[issue 14]: Initial prototype of sentiment dashboard
@parente parente merged commit 3b94ecb into jupyter:master Oct 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants