Make Jupyter Notebook 4.x the minimum baseline #93
Conversation
|
@lbustelo Have a look at this PR for all the Makefile, etc. updates. Widgets are going to differ of course, but it's a starting point. I'll hold this PR here until widgets have a 4.x compatibility PR that I can finish testing all our widget dashboard examples against. |
|
Rebased today since master has change quite a bit since I opened the PR. |
| .PHONY: build clean dev help sdist test install remote | ||
| .PHONY: clean dev dev-with-widgets help install js sdist test | ||
|
|
||
| REPO:=jupyter/pyspark-notebook:a388c4a66fd4 |
There was a problem hiding this comment.
Why the use of this tag vs jupyter/pyspark-notebook:4.0 ?
There was a problem hiding this comment.
https://github.com/jupyter/docker-stacks#stacks-tags-versioning-and-progress
tl;dr: 4.0 is legacy.
|
Rebased on master (0.2.0.dev). Added two additional commits to account for changes. Manually tested all demos that do not require declarative widgets. |
* Adopt jupyter project versioning scheme * Bump to 0.2.0.dev * Introduce make build target for dev image including bower * Update dev automation for 4.x config, path changes (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
* Remove cell selection border color * Handle new image double click overflow behavior (css not js) (c) Copyright IBM Corp. 2015
* Remove test_converter_layout, precursor to local deploy (c) Copyright IBM Corp. 2015
* No host npm * make build before test * No need to prefetch docker image (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
|
Tested a whole slew of demos using what's in the jupyter/declarativewidgets#114 PR. Fixed on e error in the dashboard.js (init function now required). Everything else was solid. |
parente
changed the title
(c) Copyright IBM Corp. 2015
Make Jupyter Notebook 4.x the minimum baseline
Fixes issue #49
Merging pending ability to test and update declarative widget dashboard examples based on jupyter/declarativewidgets#67