Enable building arm images for every image except tensorflow-notebook #1446
Conversation
| @@ -64,6 +64,7 @@ RUN mamba install --quiet --yes \ | |||
| 'r-caret' \ | |||
| 'r-crayon' \ | |||
| 'r-devtools' \ | |||
| 'r-e1071' # dependency of the caret R package \ | |||
There was a problem hiding this comment.
We install r-caret here and have this in r-notebook.
And, without this line, build doesn't work for arm.
I don't really want to dwell into details the cause of the problem, but it makes 100% sense to have everything for r-notebook here, especially because we tell that we do this.
https://jupyter-docker-stacks.readthedocs.io/en/latest/using/selecting.html#jupyter-datascience-notebook
| datascience-notebook \ | ||
| pyspark-notebook \ | ||
| all-spark-notebook | ||
| # Images that can only be built on the amd64 architecture (aka. x86_64) | ||
| AMD64_ONLY_IMAGES:= \ | ||
| tensorflow-notebook |
There was a problem hiding this comment.
Tensorflow is a bit tricky because there are no official wheels for arm.
I will find some more-or-less official wheels and support tensorflow as well.
There was a problem hiding this comment.
Hmmmm hmmmmm, if it comes to installing separate non-official packages, is it really worth the long term maintenance effort?
Ok, I think I agree with you on this 👍 I updated the docs to reflect that we only do not support If tensorflow arm will be really popular one day, I think there will be an arm wheel. For now, I think 7 out of 8 is good enough to close the issue 🎉 |
Fix: #1019