Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building arm images for every image except tensorflow-notebook #1446

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Enable building arm images for every image except tensorflow-notebook #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8704f70
Enable building arm images for every image except tensorflow-notebook
Aug 25, 2021
c85f242
Update docs
Aug 25, 2021
4504d63
Do not build datascience-notebook yet
Aug 26, 2021
e81474c
Fix docs :(
Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ MULTI_IMAGES:= \
base-notebook \
minimal-notebook \
r-notebook \
scipy-notebook
scipy-notebook \
pyspark-notebook \
all-spark-notebook
# Images that can only be built on the amd64 architecture (aka. x86_64)
AMD64_ONLY_IMAGES:= \
tensorflow-notebook \
datascience-notebook \
pyspark-notebook \
all-spark-notebook
tensorflow-notebook
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tensorflow is a bit tricky because there are no official wheels for arm.
I will find some more-or-less official wheels and support tensorflow as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm hmmmmm, if it comes to installing separate non-official packages, is it really worth the long term maintenance effort?

# All of the images
ALL_IMAGES:= \
base-notebook \
Expand Down
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ This change is tracked in the issue [#1217](https://github.com/jupyter/docker-st

## CPU Architectures

All published containers support amd64 (x86_64).
The progress on arm images is tracked in [#1019](https://github.com/jupyter/docker-stacks/issues/1019).
The ambition is to have all containers support both amd64 and arm64.
All published containers support amd64 (x86_64) and aarch64, except for datascience and tensorflow, which only support amd64 for now.

### Caveats for arm64 images

Expand Down
1 change: 1 addition & 0 deletions datascience-notebook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ RUN mamba install --quiet --yes \
'r-caret' \
'r-crayon' \
'r-devtools' \
'r-e1071' # dependency of the caret R package \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We install r-caret here and have this in r-notebook.
And, without this line, build doesn't work for arm.

I don't really want to dwell into details the cause of the problem, but it makes 100% sense to have everything for r-notebook here, especially because we tell that we do this.
https://jupyter-docker-stacks.readthedocs.io/en/latest/using/selecting.html#jupyter-datascience-notebook

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

'r-forecast' \
'r-hexbin' \
'r-htmltools' \
Expand Down
4 changes: 1 addition & 3 deletions docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ Docker destroys the container after notebook server exit, but any files written
CPU Architectures
-----------------

All published containers support amd64 (x86_64).
The progress on arm images is tracked in `#1019 <https://github.com/jupyter/docker-stacks/issues/1019>`_.
The ambition is to have all containers support both amd64 and arm64.
All published containers support amd64 (x86_64) and aarch64, except for datascience and tensorflow, which only support amd64 for now.

Caveats for arm64 images
^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down