Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests (test_client.py::TestKernelClient) with python 3.10.9 in 7.x #901

Closed
danigm opened this issue Dec 15, 2022 · 3 comments
Closed

Comments

@danigm
Copy link

danigm commented Dec 15, 2022

With the latest release of python 3.10 (3.10.9) some tests are failing:

https://github.com/danigm/jupyter_client/actions/runs/3702076899/jobs/6271964221

It looks like it's related to the run_sync function in utils.py: https://github.com/jupyter/jupyter_client/blob/7.x/jupyter_client/utils.py#L16-L21

@davidbrochart
Copy link
Member

Thanks for reporting @danigm.
We are getting rid of nest-asyncio, run_sync now runs in another event loop in a separate thread.
Would you be able to test v8.0.0a0?

danigm added a commit to danigm/jupyter_client that referenced this issue Dec 15, 2022
@danigm
Copy link
Author

danigm commented Dec 15, 2022

Thanks for reporting @danigm. We are getting rid of nest-asyncio, run_sync now runs in another event loop in a separate thread. Would you be able to test v8.0.0a0?

I tried to run the tests with python 3.10.9 for 8.0, but it looks like it's failing for a different reason: https://github.com/danigm/jupyter_client/actions/runs/3702412290/jobs/6272676495

danigm added a commit to danigm/jupyter_client that referenced this issue Dec 15, 2022
@blink1073
Copy link
Member

I tested against 3.10.10 and verified that it passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants