Make run_sync compatible with python 3.10.9 #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
Dec 15, 2022
jupyter_client/utils.py
Outdated
| except RuntimeError: | ||
| # In python 3.10.9 this workaround breaks some tests | ||
| # test_client.TestKernelClient | ||
| # https://docs.python.org/3.10/whatsnew/changelog.html#id3 |
There was a problem hiding this comment.
Maybe add a more specific link?
There was a problem hiding this comment.
Updated, I've used the link to the cpython github issue: python/cpython#83710
| except RuntimeError: | ||
| loop = asyncio.new_event_loop() | ||
| asyncio.set_event_loop(loop) | ||
| else: |
There was a problem hiding this comment.
I think this changes the behavior. In the else, should we try to use get_running_loop before creating a new event loop?
|
Note that the deprecation warning will be reverted in the next patch release of 3.10 and 3.11. I think we should ignore the warning instead of adding a workaround for a single patch release. cf python/cpython#93453 (comment) |
|
I tested against 3.10.10 and verified that it passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make run_sync compatible with python 3.10.9
Fix #901