don't log full env when starting kernels fails #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it could contain sensitive info like API keys. PATH is included explicitly, but no other env is logged. This does hide useful info like PYTHONPATH, locale, etc. but there is no way to maintain a safe language-agnostic env whitelist.
|
Alternative: include env keys, but not values. However, one could argue that even the presence of certain keys should not be disclosed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it could contain sensitive info like API keys.
PATH is included explicitly, but no other env is logged.
This does hide useful info like PYTHONPATH, locale, etc. but there is no way to maintain a safe language-agnostic env whitelist.
cc @jasongrout
closes jupyter/notebook#1714