Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception cause in ptshell.py #220

Merged
merged 1 commit into from Aug 26, 2020
Merged

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 12, 2020

I recently went over Matplotlib, Pandas and NumPy, fixing a small mistake in the way that Python 3's exception chaining is used. If you're interested, I can do it here too. I've done it on just one file right now.

The mistake is this: In some parts of the code, an exception is being caught and replaced with a more user-friendly error. In these cases the syntax raise new_error from old_error needs to be used.

Python 3's exception chaining means it shows not only the traceback of the current exception, but that of the original exception (and possibly more.) This is regardless of raise from. The usage of raise from tells Python to put a more accurate message between the tracebacks. Instead of this:

During handling of the above exception, another exception occurred:

You'll get this:

The above exception was the direct cause of the following exception:

The first is inaccurate, because it signifies a bug in the exception-handling code itself, which is a separate situation than wrapping an exception.

Let me know what you think!

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 21, 2020

@Carreau What do you think?

@Carreau
Copy link
Member

Carreau commented Jun 21, 2020

No objection, there is just a lot of work that need to be done to review and bring the jupyter_console up to date.

@Carreau Carreau merged commit 986bd01 into jupyter:master Aug 26, 2020
@Carreau
Copy link
Member

Carreau commented Aug 26, 2020

Thanks.

@cool-RR
Copy link
Contributor Author

cool-RR commented Aug 27, 2020

Woohoo! I'll see when I have time to do the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants