New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception causes all over the codebase #16706
Conversation
0fc9899
to
40d7449
Compare
@timhoffm Ready for review |
Maybe you could include a few words as to why we want to use this grammar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look fine to me. Would be nice if the test coverage was better, but don't expect you to write a bunch of tests that trigger exceptions...
Thanks @cool-RR ! |
I just made a blog post about this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with |
PR Summary
PR Checklist