Use GetUserNameEx to get SID of current user to secure win32 files #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that the SID obtained when using GetUserName was causing permission issues because it wasn't the actual SID for the current user. By changing the call to use `GetUserNameEx` with a parameter of `NameSamCompatible`, the SID that was returned did indeed correspond to the current user. In addition, analysis of the file using Windows explorer also showed the SID being resolved to the current user's Windows ID, rather than a raw SID (as before). Co-authored-by: snapo <6347922+snapo@users.noreply.github.com>
|
I tested this in as many ways as I could, and the changes all seem to work.
One thing I was not able to test was:
|
MSeal
approved these changes
Sep 30, 2019
|
@minrk - this is the last of the changes that are needed for 4.6.0. Could you please cut a release as soon as possible? |
|
@takluyver Do you have merge / release permissions? There's a lot of downstream issues being opened waiting on this fix. |
|
Thank you @rgbkrk! |
|
Check your email for an ask to get you both to have release permissions on |
|
Will do - thank you. Is this a "be careful what you wish for" moment? 😄 |
|
|
|
Just happy to enable you all to keep things moving. |
|
Thanks for getting this through, everyone! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the SID obtained when using GetUserName was causing permission
issues because it wasn't the actual SID for the current user. By changing
the call to use
GetUserNameExwith a parameter ofNameSamCompatible,the SID that was returned did indeed correspond to the current user. In
addition, analysis of the file using Windows explorer also showed the SID
being resolved to the current user's Windows ID, rather than a raw SID (as
before).
Co-authored-by: snapo 6347922+snapo@users.noreply.github.com