Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pywin32 package on PyPy #230

Merged
merged 2 commits into from Aug 3, 2021
Merged

Remove dependency on pywin32 package on PyPy #230

merged 2 commits into from Aug 3, 2021

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented May 25, 2021

Fix #226 and #229

This PR makes jupyter_core compatible with PyPy on Win32. The main issue is that the pywin32 package does not yet support PyPy (mhammond/pywin32#1289).

Changes:

  1. add an alternative Ctypes implementation of the win32_restrict_file_to_user function, which is used as a fallback if the pywin32 package is not installed
  2. change install_requires to exclude pywin32 on PyPy
  3. allow AttributeError: 'stat_result' object has no attribute 'st_file_attributes' to pass silently

Tested with pypy3.7-v7.3.5.

@stonebig
Copy link

is there still a chance to get a jupyter_core-4.7.2 patch release with this in June ?

@stonebig
Copy link

stonebig commented Jun 13, 2021

it would be a small step for jupyter-core, but a great jump for PyPy visibility, as with the patch, Jupyter eco-system works on PyPy till seaborn, bqplot, ipyleaflet, matplotlib widget, bokeh, holoviews...
image

@minrk minrk merged commit ac47bd9 into jupyter:master Aug 3, 2021
@minrk
Copy link
Member

minrk commented Aug 3, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove false dependency on pywin32
4 participants