Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to shift+click for multiple cell selection in the notebook #710

Closed
ellisonbg opened this issue Aug 19, 2016 · 6 comments · Fixed by #1153
Closed

Add ability to shift+click for multiple cell selection in the notebook #710

ellisonbg opened this issue Aug 19, 2016 · 6 comments · Fixed by #1153
Assignees
Labels
pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX tag:Feature Parity
Milestone

Comments

@ellisonbg
Copy link
Contributor

In the classic notebook you can shift+click to select multiple cells. Add that to JupyterLab :)

@ellisonbg
Copy link
Contributor Author

Plan:

  • Add click handler to notebook/widget
  • Add method to handle that event to notebook widget
  • Test for shift (abort otherwise)
  • Find selected cell and clicked cell.
  • Import NotebookActions
  • Call NotebookActions.extend... multiple times

@jasongrout
Copy link
Contributor

jasongrout commented Aug 30, 2016

multiple times

I think it might be better to make the extend function take a cell (or index), instead of rerunning its logic for every cell in between the active and clicked cells.

@blink1073
Copy link
Contributor

or merge to an extendSelectionTo(index: number) function

@ellisonbg
Copy link
Contributor Author

@spoorthyv any update on this one?

@spoorthyv
Copy link
Contributor

spoorthyv commented Sep 6, 2016

I need some help with implementing an extendSelectionTo function. I was able to find the index of the target cell and pass that to the function, but I cant find a way to pass the index of the cell that is already selected.

@blink1073
Copy link
Contributor

if you have the Notebook widget instance, you can call isSelected() on each cell.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX tag:Feature Parity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants