Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of the Linux JS Tests / Notebook and Base Test Failures in CI Job #103

Merged
merged 3 commits into from May 24, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented May 24, 2022

This PR is in progress to fix some of the JS test failure from the CI checks.

@RRosio RRosio marked this pull request as ready for review May 24, 2022 15:40
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @RRosio

@RRosio RRosio changed the title Fix Linux JS Tests CI Job Fix part of the Linux JS Tests / Notebook and Base Test Failures in CI Job May 24, 2022
@echarles echarles added the bug Something isn't working label May 24, 2022
@echarles echarles merged commit 89b046a into jupyter:main May 24, 2022
@echarles
Copy link
Member

Congratulation @RRosio for your first merged PR 👍

@RRosio RRosio deleted the ci/js_tests branch May 24, 2022 16:33
@RRosio
Copy link
Collaborator Author

RRosio commented May 24, 2022

Thank you so much for all your guidance @echarles!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants