Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax assert for IPythonHandler in case of notebook<6 #122

Merged
merged 1 commit into from Jul 5, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Jul 5, 2022

Fixes #120
Fixes #121

@echarles
Copy link
Member Author

echarles commented Jul 5, 2022

@blink1073 This one is good to go. The CI failures are not relevant to these changes.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@echarles echarles merged commit c1a0de3 into jupyter:main Jul 5, 2022
@echarles
Copy link
Member Author

echarles commented Jul 5, 2022

Super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with nbclassic==0.4.0, JupyterLab<4 and notebook<7 /tree shows 404 after upgrading to 0.4.0
2 participants