Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require two different minimal versions of jupyter_server #208

Merged
merged 1 commit into from Jan 29, 2023
Merged

Don't require two different minimal versions of jupyter_server #208

merged 1 commit into from Jan 29, 2023

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jan 27, 2023

It works but is confusing.

@echarles
Copy link
Member

Thx @hroncok. I would rather set the floor boundary to the latest version 1 jupyter_server, so jupyter_server>=1.23.5
https://pypi.org/project/jupyter-server/#history

WDYT?

@hroncok
Copy link
Contributor Author

hroncok commented Jan 29, 2023

That can be done I guess, but I'd rather get this minimal change in first.

echarles
echarles approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nbclassic works fine with jupyter_server 1.8. Thx @hroncok

@echarles echarles merged commit 80b3b05 into jupyter:main Jan 29, 2023
@hroncok hroncok deleted the patch-1 branch January 29, 2023 08:06
@hroncok
Copy link
Contributor Author

hroncok commented Jan 29, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hroncok @echarles