Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Test Fixes Round 2 #212

Merged
merged 4 commits into from Jan 31, 2023
Merged

Conversation

ericsnekbytes
Copy link
Collaborator

This PR fixes test_save_readonly_as.py errors. This update reflects a new testing approach that better handles the variability in test behaviors and execution times experienced in CI and local test runs (There's less reliance on application state transitions that happen in a user workflow to advance the testing procedure forward).

  • The save prompt may close instantaneously, or linger for a long time...the test now handles both of these scenarios
  • New locators and checks are used to drive the test forward
  • Diagnostic messages are now printed during different test steps, to provide data and debugging information for both successful and unsuccessful test runs

See also, previous related PRs (this and this).

@ericsnekbytes ericsnekbytes added bug Something isn't working maintenance labels Jan 31, 2023
@ericsnekbytes ericsnekbytes marked this pull request as ready for review January 31, 2023 16:29
@RRosio
Copy link
Collaborator

RRosio commented Jan 31, 2023

LGTM thanks @ericsnekbytes!!

@RRosio RRosio merged commit e3cabee into jupyter:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants