Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch server's sorted_extensions to prioritize nbclassic #56

Merged
merged 1 commit into from
May 20, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 19, 2021

This reverts #49. (@minrk)

nbclassic's nbserver server extension attempts to load classic server extensions (found in the old server config locations) with the new jupyter server.

It's critical that nbclassic be loaded before these extensions to ensure that nbclassic's NotebookApp class is initialized. because some of these server extensions might try to set traits on NotebookApp (that weren't ported+shimmed to ServerApp).

An example: jupyter_nbexetensions_configurator sets nbextensions_path, a trait in the classic NotebookApp. Nbclassic should pick up this trait, but can't if it's not initialized.

This depends on jupyter-server/jupyter_server#522, so we should wait to merge until jupyter_server merges and releases.

@minrk
Copy link
Member

minrk commented May 20, 2021

Can we add a test for this? When I was working on #49 I wasn't able to identify anything that didn't work, so it would be helpful to track that if it breaks in the future.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Member

Can we add a test for this?

Do you mind opening a new issue to track this integration test?

@blink1073 blink1073 merged commit 0df2d33 into jupyter:master May 20, 2021
@jtpio
Copy link
Member

jtpio commented May 21, 2021

This depends on jupyter-server/jupyter_server#522, so we should wait to merge until jupyter_server merges and releases.

Looks like we could then bump to jupyter_server~=1.8?

https://github.com/jupyterlab/nbclassic/blob/979b2cfbd39f18e427a14673b85d2ee2b53f83c0/setup.py#L58

@vidartf
Copy link
Contributor

vidartf commented May 26, 2021

Can we add a test for this?

Do you mind opening a new issue to track this integration test?

#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants