Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix the Docs Tests job #99

Merged
merged 21 commits into from May 24, 2022
Merged

Conversation

echarles
Copy link
Member

@echarles echarles commented May 13, 2022

This PR aims to fix the CI docs job.

@echarles echarles changed the title [CI] Fix the docs job [CI] Fix the Doc Test job May 13, 2022
@echarles echarles marked this pull request as ready for review May 13, 2022 16:21
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
echarles and others added 3 commits May 18, 2022 17:19
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
@echarles
Copy link
Member Author

Thx for the reviews @afshin. I have merged your suggestions.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
Co-authored-by: Afshin Taylor Darian <git@darian.email>
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
echarles and others added 14 commits May 20, 2022 10:19
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
Co-authored-by: Afshin Taylor Darian <git@darian.email>
@echarles
Copy link
Member Author

@afshin I should have searched more for notebook instances and should have changed them. Thx a lot for passing on all those changes for me. I have merged them. I have double checked the contributing.rst file and now it looks ok.

@echarles
Copy link
Member Author

@afshin If these changes sounds good to you, could you approve? I will then merge and we will get one more job green :)

@echarles echarles changed the title [CI] Fix the Doc Test job [CI] Fix the Docs Tests job May 24, 2022
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, @echarles!

@afshin afshin merged commit 46df250 into jupyter:main May 24, 2022
@echarles
Copy link
Member Author

Super. Thx @afshin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants