-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-execution
cell tag functionality
#151
Conversation
I guess this is also related to https://discourse.jupyter.org/t/is-there-a-cell-tag-convention-to-skip-execution/5445, but nothing really come of that, so I wanted to be a bit more direct 😬 I guess you could add a traitlets options, which disabled this feature by default; so it is not a potentially breaking change for anyone else, but allowed us folks that want do want to have such functionality to use it (acknowledging the disclaimer that it is maybe a "bad" practice). |
I think it can be useful, but maybe we could make it more generic? For instance, if we decide to make it configurable through a trait, we could have one such as |
that works for me cheers 😄 will update the PR in a bit... |
Hey @davidbrochart I have updated the PR with the |
oops fixed flake8 (fancy me adding a pre-commit config for that and maybe black, and mypy?) |
Sure, thanks. |
I'll do that in another PR ta |
Co-authored-by: David Brochart <david.brochart@gmail.com>
@takluyver we are seeing the same error as in #159 ( |
Awesome, thanks! |
This is something that has been requested and up-voted in jupyter-book/jupyter-book#833
I guess this is the simplest implementation, although happy to discuss (a) if you would back this idea in the first place and (b) is you think any more configuration is needed (e.g. at the traitlets level)