Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip-execution cell tag functionality #151

Merged
merged 5 commits into from
Sep 17, 2021

Conversation

chrisjsewell
Copy link
Contributor

This is something that has been requested and up-voted in jupyter-book/jupyter-book#833

I guess this is the simplest implementation, although happy to discuss (a) if you would back this idea in the first place and (b) is you think any more configuration is needed (e.g. at the traitlets level)

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Aug 4, 2021

I guess this is also related to https://discourse.jupyter.org/t/is-there-a-cell-tag-convention-to-skip-execution/5445, but nothing really come of that, so I wanted to be a bit more direct 😬

I guess you could add a traitlets options, which disabled this feature by default; so it is not a potentially breaking change for anyone else, but allowed us folks that want do want to have such functionality to use it (acknowledging the disclaimer that it is maybe a "bad" practice).

@davidbrochart
Copy link
Member

I think it can be useful, but maybe we could make it more generic? For instance, if we decide to make it configurable through a trait, we could have one such as skip_cells_with_tag=skip-execution, what do you think?

@chrisjsewell
Copy link
Contributor Author

we could have one such as skip_cells_with_tag=skip-execution, what do you think?

that works for me cheers 😄 will update the PR in a bit...

@chrisjsewell
Copy link
Contributor Author

Hey @davidbrochart I have updated the PR with the skip_cells_with_tag trait

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Sep 15, 2021

oops fixed flake8 (fancy me adding a pre-commit config for that and maybe black, and mypy?)

@davidbrochart
Copy link
Member

fancy me adding a pre-commit config for that and maybe mypy?

Sure, thanks.

@chrisjsewell
Copy link
Contributor Author

Sure, thanks.

I'll do that in another PR ta

nbclient/client.py Outdated Show resolved Hide resolved
Co-authored-by: David Brochart <david.brochart@gmail.com>
@davidbrochart
Copy link
Member

@takluyver we are seeing the same error as in #159 (zmq.error.ZMQError: Address already in use).

@davidbrochart
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants