Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution timing in code cell metadata for v4 spec #32

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Add execution timing in code cell metadata for v4 spec #32

merged 3 commits into from
Feb 29, 2020

Conversation

davidbrochart
Copy link
Member

No description provided.

@davidbrochart davidbrochart marked this pull request as ready for review February 28, 2020 14:46
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to add a test that the timing values get assigned as expected in the resulting notebook document. And to check they have a format conforming (in case someone refactors timestamp).

@davidbrochart
Copy link
Member Author

I added a test which checks for expected timing values and format. I think it's ready to be merged now.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests

@MSeal MSeal merged commit 1fbaeb5 into jupyter:master Feb 29, 2020
@davidbrochart davidbrochart deleted the execution_timing branch February 29, 2020 22:27
@MSeal MSeal added this to the 0.2.0 milestone Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants