Split start_new_kernel_client into kernel and client creation #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSeal
approved these changes
Jul 30, 2020
|
I'll wait for Sylvain to take a look to merge |
MSeal
approved these changes
Aug 9, 2020
|
Going to merge since it's been a bit without other input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates
(async_)start_new_kernel_clientinto:(async_)start_new_kernel: starts a new kernel.(async_)start_new_kernel_client: starts a new client of the kernel.This gives more flexibility as to creating the kernel and/or the client from outside. Internally, both methods are called so it doesn't change anything.
Also in this PR:
start_kernel_managerrenamed tocreate_kernel_manager(see Rename start_kernel_manager into create_kernel_manager #92).self.owns_kmindicates if the kernel manager is created by theNotebookClientor if it is passed from outside. If theNotebookClientowns the kernel manager, the cleanup of the kernel (client and manager) will be done by default. If not, the cleanup won't be done by default (previously, it was always done by default).