Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward incompatible change in patch release #103

Closed
SylvainCorlay opened this issue Aug 27, 2020 · 5 comments
Closed

Backward incompatible change in patch release #103

SylvainCorlay opened this issue Aug 27, 2020 · 5 comments

Comments

@SylvainCorlay
Copy link
Member

It seems that we should have tagged a 0.5 instead of 0.4.2. #94 was a (much needed) backward incompatible change.

I suggest we tag a 0.5 right away and remove the 0.4.2 and 0.4.3 uploads as broken.

@SylvainCorlay
Copy link
Member Author

cc @davidbrochart @MSeal

@MSeal
Copy link
Contributor

MSeal commented Aug 27, 2020

Sure, I can do that now. Thanks for raising. For others who have a pinned download issue in future, please update to 0.5.0 -- it's equivalent to 0.4.3.

@MSeal
Copy link
Contributor

MSeal commented Aug 27, 2020

Ok the those two patch releases are yanked (but not deleted) so they'll still resolve for exact matches (e.g. nbclient==0.4.2) but pip will avoid them for any other version specification pattern.

@MSeal
Copy link
Contributor

MSeal commented Aug 27, 2020

I'll leave this issue open for a bit so it's visible for anyone who comes searching about release changes

@SylvainCorlay
Copy link
Member Author

Ok the those two patch releases are yanked (but not deleted) so they'll still resolve for exact matches (e.g. nbclient==0.4.2) but pip will avoid them for any other version specification pattern.

Excellent! I had not thought of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants