Don't use a shell to call inkscape #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python generally recommends against using `shell=True` when calling subprocesses (https://docs.python.org/3/library/subprocess.html#security-considerations). This also causes issues with shell metacharacters (see #1469). I'm also not entirely sure that the shell command *is* fully trustable - I don't know where {to_filename} and {from_filename} are from. Rest of nbconvert also prefers using lists instead of strings to call commands. svg2pdf also uses a command instead of a string now. We leave the old string implementation alone for backwards compatibility, although I'd really prefer to remove it. We don't need the quotes set up in #1469, since using a list automatically deals with that.
This was referenced Feb 3, 2021
technic
reviewed
Mar 14, 2021
nbconvert/preprocessors/svg2pdf.py
Outdated
| # For backwards compatibility with specifying strings | ||
| # Okay-ish, since the string is trusted | ||
| full_cmd = self.command.format(*template_vars) | ||
| subprocess.call(full_cmd, shell=isinstance(str)) |
agoose77
reviewed
Apr 8, 2021
nbconvert/preprocessors/svg2pdf.py
Outdated
| @@ -62,26 +62,37 @@ def _inkscape_version_default(self): | |||
| raise RuntimeError("Unable to find inkscape executable --version") | |||
| return output.decode('utf-8').split(' ')[1] | |||
|
|
|||
| command = Unicode( | |||
| help="""The command to use for converting SVG to PDF | |||
| # FIXME: Deprecate passing a list here | |||
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| # FIXME: Deprecate passing a list here | |
| # FIXME: Deprecate passing a string here |
MSeal
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python generally recommends against using
shell=Truewhen calling
subprocesses (https://docs.python.org/3/library/subprocess.html#security-considerations).
This also causes issues with shell metacharacters (see
#1469). I'm also
not entirely sure that the shell command is fully trustable
from. Rest of nbconvert also prefers using lists instead
of strings to call commands.
svg2pdf also uses a command instead of a string now. We leave
the old string implementation alone for backwards compatibility,
although I'd really prefer to remove it.
We don't need the quotes set up in
#1469,
since using a list automatically deals with that.