Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a shell to call inkscape #1512

Merged
merged 3 commits into from Jun 7, 2021
Merged

Don't use a shell to call inkscape #1512

merged 3 commits into from Jun 7, 2021

Commits on Feb 3, 2021

  1. Don't use a shell to call inkscape

    Python generally recommends against using `shell=True`
    when calling
    subprocesses (https://docs.python.org/3/library/subprocess.html#security-considerations).
    This also causes issues with shell metacharacters (see
    #1469). I'm also
    not entirely sure that the shell command *is* fully trustable
    - I don't know where {to_filename} and {from_filename} are
    from. Rest of nbconvert also prefers using lists instead
    of strings to call commands.
    
    svg2pdf also uses a command instead of a string now. We leave
    the old string implementation alone for backwards compatibility,
    although I'd really prefer to remove it.
    
    We don't need the quotes set up in
    #1469,
    since using a list automatically deals with that.
    yuvipanda committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    f40714e View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Fix call to isinstance

    yuvipanda committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    446210f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c003a5e View commit details
    Browse the repository at this point in the history