-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.5 #168
Comments
Yeah I can do that, was about to kick off a 6.1.2 release for jupyter client as well |
Thanks! |
Hmmm, in sagemathinc/cocalc#4472, @williamstein says that cocalc has been generating notebook format version 4.0 notebooks with widgets displayed in them, and of course they've been working with nbformat package version 4.x. In #167, we only retroactively modified format version 4.1, but perhaps we should also retroactively modify format version 4.0, if those notebooks are also in the wild? @minrk? |
I think it's reasonably safe to extend that to 4.0 if you want to PR it |
PR submitted and merged: #169. Let me ping the steering council about this and report back by Monday before we release these changes. Especially when we are dealing with retroactively changing formats, which is the very foundational layer of Jupyter, it would be good to flag things for wider review or comment. |
@jasongrout -- thanks! |
To be clear, this discussion is happening in public on #170, so there is nothing more to report back from a steering council discussion. |
@jasongrout I've released 5.0.5 -- however I don't have permissions to the npm package update (for username |
It looks like @minrk and @rgbkrk are the ones that have permissions to publish https://www.npmjs.com/package/nbformat-schema. I'd also love to have permission to publish that npm package. |
I'll add you on @jasongrout as well @SylvainCorlay. Anybody else that should be added on to the JS package? |
Ok I've added quite a few more folks that are maintainers on jupyterlab packages. Let me know if this is sufficient, otherwise feel free to add the people you think should be on the npm package Jason. |
Thanks Kyle -- I'll try releasing the npm package now |
Even though Matt et. al. were added to the npm package, it didn't seem to let him publish. I went ahead and published 5.0.5. |
Thanks @rgbkrk -- Closing this issue as it's fully released now |
Thanks Kyle and Matt! |
@MSeal, @minrk (or whoever else can) - can we have a 5.0.5 release of nbformat that includes #167, so people can stop having issues with noncompliant notebooks with format version 4.1?
The text was updated successfully, but these errors were encountered: