Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.5 #168

Closed
jasongrout opened this issue Mar 26, 2020 · 15 comments
Closed

Release 5.0.5 #168

jasongrout opened this issue Mar 26, 2020 · 15 comments

Comments

@jasongrout
Copy link
Member

@MSeal, @minrk (or whoever else can) - can we have a 5.0.5 release of nbformat that includes #167, so people can stop having issues with noncompliant notebooks with format version 4.1?

@MSeal
Copy link
Contributor

MSeal commented Mar 26, 2020

Yeah I can do that, was about to kick off a 6.1.2 release for jupyter client as well

@jasongrout
Copy link
Member Author

Thanks!

@jasongrout
Copy link
Member Author

Hmmm, in sagemathinc/cocalc#4472, @williamstein says that cocalc has been generating notebook format version 4.0 notebooks with widgets displayed in them, and of course they've been working with nbformat package version 4.x. In #167, we only retroactively modified format version 4.1, but perhaps we should also retroactively modify format version 4.0, if those notebooks are also in the wild? @minrk?

@MSeal
Copy link
Contributor

MSeal commented Mar 26, 2020

I think it's reasonably safe to extend that to 4.0 if you want to PR it

@jasongrout
Copy link
Member Author

PR submitted and merged: #169.

Let me ping the steering council about this and report back by Monday before we release these changes. Especially when we are dealing with retroactively changing formats, which is the very foundational layer of Jupyter, it would be good to flag things for wider review or comment.

@williamstein
Copy link
Contributor

@jasongrout -- thanks!

@jasongrout
Copy link
Member Author

Let me ping the steering council about this and report back by Monday before we release these changes.

To be clear, this discussion is happening in public on #170, so there is nothing more to report back from a steering council discussion.

@MSeal
Copy link
Contributor

MSeal commented Apr 1, 2020

@jasongrout I've released 5.0.5 -- however I don't have permissions to the npm package update (for username mseal) to promote the json changes to javascript. Someone needs to run npm publish while on the 55eae74751416095be97eb19858560b740241aae commit sha / 5.0.5 tag or add me as a valid user to do so. I'm not sure if you have permissions that in particular or not?

@jasongrout
Copy link
Member Author

It looks like @minrk and @rgbkrk are the ones that have permissions to publish https://www.npmjs.com/package/nbformat-schema. I'd also love to have permission to publish that npm package.

@rgbkrk
Copy link
Member

rgbkrk commented Apr 3, 2020

I'll add you on @jasongrout as well @SylvainCorlay. Anybody else that should be added on to the JS package?

@rgbkrk
Copy link
Member

rgbkrk commented Apr 3, 2020

Ok I've added quite a few more folks that are maintainers on jupyterlab packages. Let me know if this is sufficient, otherwise feel free to add the people you think should be on the npm package Jason.

@MSeal
Copy link
Contributor

MSeal commented Apr 3, 2020

Thanks Kyle -- I'll try releasing the npm package now

@rgbkrk
Copy link
Member

rgbkrk commented Apr 3, 2020

Even though Matt et. al. were added to the npm package, it didn't seem to let him publish. I went ahead and published 5.0.5.

@MSeal
Copy link
Contributor

MSeal commented Apr 3, 2020

Thanks @rgbkrk -- Closing this issue as it's fully released now

@MSeal MSeal closed this as completed Apr 3, 2020
@jasongrout
Copy link
Member Author

Thanks Kyle and Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants