Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch dict-like vals in __setitem__, apply from_dict() #107

Merged
merged 8 commits into from
Aug 18, 2017
Merged

Catch dict-like vals in __setitem__, apply from_dict() #107

merged 8 commits into from
Aug 18, 2017

Commits on Aug 17, 2017

  1. Catch dict-like vals in __setitem__, apply from_dict()

    @mpacer
    mpacer committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    4f3a90c View commit details
    Browse the repository at this point in the history

  2. fix docstring

    @mpacer
    mpacer committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    9b75e08 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. add update() and use super().__setitem__()

    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    0eb363e View commit details
    Browse the repository at this point in the history

  2. change dict check to Mapping check for consistency

    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    b3a1a0b View commit details
    Browse the repository at this point in the history

  3. add check on from_dict to not change NotebookNode

    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    291cdd0 View commit details
    Browse the repository at this point in the history

  4. remove from_dict calls inside updates in v4/nbbase.py to use the inte… 

    …rnal NotebookNode logic
    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    5d20566 View commit details
    Browse the repository at this point in the history

  5. redirect nbjson from_dict import to be from notebooknode

    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    a057f76 View commit details
    Browse the repository at this point in the history

  6. swap logic to check for NotebookNode to __setitem__

    @mpacer
    mpacer committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    7167b38 View commit details
    Browse the repository at this point in the history