Simplify NotebookNotary._data_dir_default #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for that function originally predates the introduction of the function `jupyter_core.paths.jupyter_data_dir` which can now be used to determine the Jupyter data directory instead of initializing an instance of JupyterApp just to figure its data directory.
This was referenced Mar 13, 2024
krassowski
added a commit
to krassowski/nbformat
that referenced
this pull request
Mar 13, 2024
ivanov
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Revert PR #378 (Simplify NotebookNotary._data_dir_default) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for that function originally predates the introduction of the function
jupyter_core.paths.jupyter_data_dirwhich can now be used to determine the Jupyter data directory instead of initializing an instance of JupyterApp just to figure its data directory.I figure this out while working on another PR for jupyter_server_fileid which uses the function to determine the data directory : https://github.com/jupyter-server/jupyter_server_fileid/blob/v0.9.0/jupyter_server_fileid/manager.py#L23