Fix version bumping for pre-releases

[jtpio]

Running the Draft Changelog on the main branch failed with the following error:

Error: Could not parse 0.8.0a0 as a valid version string

https://github.com/jtpio/jupyter_releaser/runs/7023597896?check_suite_focus=true

This looks related to bumping the version for pre-releases.

This change should fix it.

[jtpio]

This is what it looks like locally running tbump --non-interactive --only-patch 0.8.0a0:

[jtpio]

Currently the version in the top-level package.json is set to 0.8.0:

nbgrader/package.json

Line 3 in 086a81d

"version": "0.8.0",

But for 0.8.0a0 it should be set to the corresponding 0.8.0-alpha.0.

[brichet]

Currently the version in the top-level package.json is set to 0.8.0:

nbgrader/package.json

Line 3 in 086a81d

"version": "0.8.0",

But for 0.8.0a0 it should be set to the corresponding 0.8.0-alpha.0.

I agree, do you think there is a way to do that using tbump ?

[jtpio]

I agree, do you think there is a way to do that using tbump ?

hmm not sure.

But an alternative could be to run a small script as a after-bump-version hook doing something like this:

version.replace('a', '-alpha.').replace('b', '-beta.').replace('rc', '-rc.')

Similar to the cookiecutter but the other way around: https://github.com/jupyterlab/extension-cookiecutter-ts/blob/a706ffd9d5d2c2813c427d571caaab77014dae17/%7B%7Bcookiecutter.python_name%7D%7D/setup.py#L40-L45

And write the modified version back to package.json.

[brichet]

And write the modified version back to package.json.

It seems that the 2 hooks available in tbumb are before_commit and after_push.
If we modify the package.json file, don't you think that tbump will complain with a Current version string not found error on the next release.
We need a before_bump hook to reverse it.

[jtpio]

Right I meant a Jupyter Releaser hook.

Just pushed e69c9b5 to try something along these lines, will check what the check release CI job does.

[brichet]

Nice @jtpio

In tools/post-bump.py l20 is that not "-dev" instead of "dev" ?

[jtpio]

Thanks @brichet makes sense for consistency. Updated in 4a606ea

[jtpio]

Looks like the nbextensions checks are now failing.

Restarting them to see if they are just flaky.

[brichet]

This is related to selenium.webdriver :
E AttributeError: 'WebDriver' object has no attribute 'find_elements_by_css_selector'
The current version of selenium is 4.3.0. With the 4.2.0 the tests were passing.
As this branch will not support nbextension, we can just lock the version of selenium==4.2.0 for this PR, and open an issue in the 0.7.x branch.

[jtpio]

Ah indeed it looks like selenium 4.3.0 was released today:

Maybe we can fix it by pinning on 4.2.0 in a separate PR since it's likely to affect other PRs? Happy to rebase this one afterwards.

[brichet]

Maybe we can fix it by pinning on 4.2.0 in a separate PR since it's likely to affect other PRs? Happy to rebase this one afterwards.

Done in #1611

[jtpio]

@brichet this PR was rebased and CI is now passing, if you would like to have another look.

Happy to attempt a new release right after to see if that goes better that time.

[brichet]

@brichet this PR was rebased and CI is now passing, if you would like to have another look.

Happy to attempt a new release right after to see if that goes better that time.

Everything seems OK for me.

[jtpio]

Alright then let's get it in and I'll start the pre-release process right after.

[jtpio]

Looks like the "Draft Changelog" workflow went through this time: #1613