Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing . in the JS version #1614

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix missing . in the JS version #1614

merged 1 commit into from
Jun 27, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 27, 2022

Follow-up to #1610

As noticed in #1613 the JS version is missing a ..

@jtpio jtpio mentioned this pull request Jun 27, 2022
Closed
@jtpio jtpio added this to the 0.8.0 milestone Jun 27, 2022
@jtpio
Copy link
Member Author

jtpio commented Jun 27, 2022

cc @brichet for review

@brichet
Copy link
Contributor

brichet commented Jun 27, 2022

Thanks @jtpio, it's all good to me.

@jtpio
Copy link
Member Author

jtpio commented Jun 27, 2022

Thanks @brichet for the review 👍

@jtpio jtpio merged commit 840e6ab into jupyter:main Jun 27, 2022
@jtpio jtpio deleted the fix-js-version branch June 27, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @brichet