Update traitlets requirement from <5.2.0 to <5.7.0 #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [traitlets](https://github.com/ipython/traitlets) to permit the latest version. - [Release notes](https://github.com/ipython/traitlets/releases) - [Changelog](https://github.com/ipython/traitlets/blob/main/CHANGELOG.md) - [Commits](ipython/traitlets@4.0...v5.6.0) --- updated-dependencies: - dependency-name: traitlets dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
… from traitlets>=5.2
shreve
added a commit
to shreve/nbgrader
that referenced
this pull request
Mar 23, 2023
The requirement of a specific traitlets version was first set in commit 35ed7aa to be <5.2 because apparently 5.2 broke tests. The last time this line was updated was in jupyter#1704, where it was bumped up to allow the latest version at the time, 5.6, by setting the value to <5.7. There was an additional change in jupyter#1704 which sets a log level, but this seems to be backwards compatible. These changes seem to no longer be relevant as the test suite now passes with traitlets versions 5.2, 5.7, as well as many others >5. The only version I found to fail was 5.0.0. This commit loosens the version requirement to allow these other versions of the traitlets package which don't cause known conflicts, as well as allow future minor, but not major version bumps.
brichet
pushed a commit
that referenced
this pull request
Mar 23, 2023
The requirement of a specific traitlets version was first set in commit 35ed7aa to be <5.2 because apparently 5.2 broke tests. The last time this line was updated was in #1704, where it was bumped up to allow the latest version at the time, 5.6, by setting the value to <5.7. There was an additional change in #1704 which sets a log level, but this seems to be backwards compatible. These changes seem to no longer be relevant as the test suite now passes with traitlets versions 5.2, 5.7, as well as many others >5. The only version I found to fail was 5.0.0. This commit loosens the version requirement to allow these other versions of the traitlets package which don't cause known conflicts, as well as allow future minor, but not major version bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on traitlets to permit the latest version.
Release notes
Sourced from traitlets's releases.
Changelog
Sourced from traitlets's changelog.
... (truncated)
Commits
0c3655cPublish 5.6.02c5188aAdopt jupyter releaser (#806)21bdae9[pre-commit.ci] pre-commit autoupdate (#807)d04d020Use base setup dependency type (#805)d2bc579[pre-commit.ci] pre-commit autoupdate (#804)d344d48More CI Cleanup (#803)65a4725Merge pull request #802 from blink1073/ci-cleanup53d3503add codecov file98ee328more maintenance cleanup1077cfbMerge pull request #801 from blink1073/add-project-descriptionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)