Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle visibility of all student names #1775

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

tuncbkose
Copy link
Contributor

Adds a new button in gradebook_notebook_submissions view to toggle visibility of all student names, closes #951.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch AaltoSciComp/nbgrader/toggle

@tuncbkose
Copy link
Contributor Author

Failures are timeouts. They seem unrelated to me

@tuncbkose
Copy link
Contributor Author

1
2

Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tuncbkose.
I have some comments on the PR.

Also, can you add test for Notebook and Jupyterlab ?

@@ -187,6 +187,20 @@ var loadSubmittedNotebooks = function () {
});
};

// button to toggle all student names
var names_hidden = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the names have already been displayed using the eye icons, clicking on the button will do nothing the first time.
Maybe instead of a global variable we could check in the function if some names are hidden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the logic so that the button label is updated properly when pressing individual eye icons. The button's logic then depends on its label.

@tuncbkose
Copy link
Contributor Author

tuncbkose commented Jun 14, 2023

The labextension tests are not implemented properly yet. I need to fix them (and my local playwright setup). I'll request a review when they are ready.

On a related note, for the Lab 4 tests, would the tests work immediately? If needed, I can take a look into that pull request and prepare something that will work.

@brichet
Copy link
Contributor

brichet commented Jun 15, 2023

The labextension tests are not implemented properly yet. I need to fix them (and my local playwright setup). I'll request a review when they are ready.

On a related note, for the Lab 4 tests, would the tests work immediately? If needed, I can take a look into that pull request and prepare something that will work.

Thanks, I'll do it for this test.

@brichet brichet merged commit 3177072 into jupyter:main Jun 15, 2023
@tuncbkose tuncbkose deleted the toggle branch July 13, 2023 06:16
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
* toggle visibility of all student names

* Add toggle names button tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to show/toggle all student names in formgrader
2 participants