Upgrade to support jupyter_client 8 #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading the dependency spec to include v8, some python tests broke (see jupyter#1728). The tests were failing with a timeout due to indefinitely blocked IO. This originates in an infinitely-looping notebook and is caused by a misconfiguration of the client connection. Currently using `nbclient.NotebookClient` with a `jupyter_client.manager.KernelManager` results in a deadlock. nbclient doesn't seem aware of this issue because there is no test covering it. `NotebookClient` uses `AsyncKernelManager` by default. So why isn't nbgrader using it? nbgrader uses the NotebookClient via nbconvert which just realized the same issue. Up until v7.3.1, nbconvert has been hard-coding the default kernel manager to the sync version. (see jupyter/nbconvert#1964) Rather than require nbconvert>=7.3.1, this commit sets our own default value to the async kernel manager.
|
|
|
I'm not familiar but it looks like the |
|
|
|
Kicking the CI |
|
@shreve can you rebase to check the tests ? |
brichet
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading the dependency spec to include v8, some python tests broke (see #1728). The tests were failing with a timeout due to indefinitely blocked IO.
This originates in an infinitely-looping notebook and is caused by a misconfiguration of the client connection. Currently using
nbclient.NotebookClientwith ajupyter_client.manager.KernelManagerresults in a deadlock. nbclient doesn't seem aware of this issue because there is no test covering it.NotebookClientusesAsyncKernelManagerby default.So why isn't nbgrader using it? nbgrader uses the NotebookClient via nbconvert which just realized the same issue. Up until v7.3.1, nbconvert has been hard-coding the default kernel manager to the sync version. (see jupyter/nbconvert#1964)
Rather than require nbconvert>=7.3.1, this commit sets our own default value to the async kernel manager.