Clean remaining code relative to Notebook<7 #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
changed the title
shreve
pushed a commit
to shreve/nbgrader
that referenced
this pull request
Jul 8, 2024
* Remove unecessary is_lab variable in formgrader static file * Remove compatibility with NotebookApp * Handle multiple courses with JupyterHub when using Notebook
AlirezaT99
pushed a commit
to AaltoSciComp/nbgrader
that referenced
this pull request
Aug 6, 2024
* Remove unecessary is_lab variable in formgrader static file * Remove compatibility with NotebookApp * Handle multiple courses with JupyterHub when using Notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a remaining compatibility with Notebook<7:
formgraderfrontend used to handle the links to directory and notebook file with jupyterlab or notebook<7NotebookAppcompatibility. Only theServerAppwill be supported.It also adds a way to handle multiple courses using JupyterHub.
Before this PR, the links to the correct
formgraderservice was always redirected to alaburl.After this PR, if the course is clicked from a Notebook, it opens the
treeurl.