use check_call for extension installation in tests #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than Popen check_call does: - wait for it to finish - check exit code, error on nonzero
|
Thanks! Well, there are still spuriously failing tests, but this does seem to have enforced at least that the nbextensions are properly installed. I think the other failing tests are probably due to other errors, sigh. Progress, at least! 😄 |
|
@meeseeksdev backport to 0.4.x |
lumberbot-app bot
pushed a commit
that referenced
this pull request
Feb 7, 2017
rather than Popen, which just launches the program. check_call adds: - wait for it to finish - raise error on nonzero exit code should close 694, if slow extension enabling was indeed the culprit.
jhamrick
added a commit
that referenced
this pull request
Feb 8, 2017
Backport PR #700 on branch 0.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than Popen, which just launches the program.
check_call adds:
should close #694, if slow extension enabling was indeed the culprit.