Redirect raw.githubusercontent.com URLs as well as raw.github.com

[jvns]

GitHub has started using raw.githubusercontent.com for raw GitHub files as well (or instead?) of raw.github.com. These should be redirected as well.

[rgbkrk]

Thanks for the contribution!

This could be one regex of the form:

r'/url[s]?/raw\.?github(?:usercontent)?\.com/([^\/]+)/([^\/]+)/(.*)'

This just puts the usercontent piece in a non-capturing group.

[rgbkrk]

@jvns, would you be willing to fix nbviewer's use of raw URLs too?

[jvns]

Done, + added a test. I'm having some trouble running the tests, though -- do they just take a while to run?

[rgbkrk]

You win 3000 internet points from me for adding a test while you were at it.

The tests do take a little while:

(nbview)14:56:16 (master) ~/code/nbviewer$ invoke test
.........................
----------------------------------------------------------------------
Ran 25 tests in 17.925s

OK

If you dig into them, you'll see a few that request things from the web rather than serving locally. That could be part of it.

[rgbkrk]

Just fetched your branch and see a few failures. I'll check it out now.

[rgbkrk]

Missing a ? after (?:usercontent).

[rgbkrk]

After fixing that, all the tests pass except for one that should be completely unrelated to your PR (blob -> tree redirect).

Not sure if our guide lists it, but you should set a few environment variables - GITHUB_OAUTH_KEY and GITHUB_OAUTH_SECRET. Otherwise GitHub may throttle you every now and then.

[rgbkrk]

I see what you're saying now @jvns. My terminal is hanging after running invoke test now.

[jvns]

Yup -- I've been running nosetests, and it hangs no matter what. When I interrupt it, it's inside a time.sleep for some reason

[rgbkrk]

@jvns - I sent you a PR: jvns#1

[rgbkrk]

Only one of these tests don't pass for me locally, which I think is due to GitHub giving out 400s/rate-limiting us. We need to set this up to either use the encrypted secrets option for Travis with a read only OAuth Key and/or mock GitHub for what should be unit tests.

I'm going to dive into this last issue, see if I can fix it then merge it.

Thanks again @jvns.

[rgbkrk]

Alright.

https://raw.githubusercontent.com/ipython/ipython/rel-2.0.0/IPython (404s)

Does not behave the same as

https://raw.github.com/ipython/ipython/rel-2.0.0/IPython (redirects)

We can't rely on raw.githubusercontent.com to do a redirect for us and raw.github.com is going away.

[rgbkrk]

I'm going to accept this as-is and follow on with a couple patches I have to finish it off.