-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items in main menu bar slightly too low #6786
Comments
Please assign this issue to me. I will do my best and this will be my proper first open source contribution. Please assign as soon as possible. Thanks |
This would be a good first issue - @JasonWeill fixed this in JupyterLab already and may be able to point you in the right direction. |
So is this issue fixed ? Thanks |
It may not be fixed in Notebook, but if you make a CSS change in Lumino, you may effect desired changes in both JupyterLab and Notebook. (I couldn't find a PR of mine specifically in JupyterLab about menu bar positioning.) |
Thanks will look into the issue. |
@codingsagar The I would recommend looking at the Lumino ( |
Sir, If I am not wrong as you can see in the above screenshot the web view in which clearly there is a border top but not border bottom so due to that the menu items are not vertically placed properly they are a px down due to that border and I don't get it why to give them border if transparent but that's okay. As then in Lumino you can see the below screenshot same class but no border top as someone fixed it maybe. |
has this issue been fixed or is it still open? |
I'm still seeing it in tip of |
The code seems to be imported from the In JupyterLab (top) and Jupyter Notebook (bottom) you can see that the pulldown menus have a very similar appearance. |
Because this bug is also present in JupyterLab, I opened a bug in JupyterLab: jupyterlab/jupyterlab#16108 Closing this issue. Let's continue the discussion in the issue linked above. |
In Notebook 7.0.0a17, items in main menu bar are a px (or 2) too low just like JupyterLab used to be.
This was found by @ellisonbg during a bug bash.
The text was updated successfully, but these errors were encountered: