Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Settings editor does not show anything #6854

Closed
jtpio opened this issue Apr 28, 2023 · 7 comments · Fixed by #6864
Closed

Advanced Settings editor does not show anything #6854

jtpio opened this issue Apr 28, 2023 · 7 comments · Fixed by #6864
Labels
bug jupyterlab Issues that belong to the jupyterlab repo
Milestone
7.0.x

Comments

@jtpio
Copy link
Member

jtpio commented Apr 28, 2023

Likely related to #6838 or #6853

image
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 28, 2023
@jtpio jtpio added this to the 7.0 milestone Apr 28, 2023
@jtpio
Copy link
Member Author

jtpio commented Apr 28, 2023

Fixing this should add UI tests to help catch such regressions in the future.

@jtpio jtpio added the bug label Apr 28, 2023
@jtpio
Copy link
Member Author

jtpio commented Apr 28, 2023

Actually seems to be an issue in JupyterLab:

image

@jtpio jtpio added the jupyterlab Issues that belong to the jupyterlab repo label Apr 28, 2023
@jtpio jtpio mentioned this issue Apr 28, 2023
Closed
@jtpio
Copy link
Member Author

jtpio commented Apr 28, 2023 •
edited
Loading

Upstream issue: jupyterlab/jupyterlab#14440

@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label May 2, 2023
@andrii-i
Copy link
Contributor

andrii-i commented May 2, 2023

Looking into jupyterlab/jupyterlab#14440

@JasonWeill JasonWeill mentioned this issue May 2, 2023
Closed
@jtpio jtpio modified the milestones: 7.0, 7.0.x May 3, 2023
@andrii-i andrii-i mentioned this issue May 3, 2023
Merged
@andrii-i
Copy link
Contributor

andrii-i commented May 3, 2023

jupyterlab/jupyterlab#14486 would transitively fix this.

Am I correct that for Notebook to get this fix, a version of the JupyterLab including the fix should be released and then Notebook would neeed to update dependency to the new version of JupyterLab?

@jtpio
Copy link
Member Author

jtpio commented May 4, 2023

Am I correct that for Notebook to get this fix, a version of the JupyterLab including the fix should be released and then Notebook would neeed to update dependency to the new version of JupyterLab?

Yes that's correct.

@andrii-i andrii-i mentioned this issue May 4, 2023
Open
@andrii-i
Copy link
Contributor

andrii-i commented May 4, 2023 •
edited
Loading

PR jupyterlab/jupyterlab#14486 was merged but it does not have a test case as described in this comment (could use an advise too). I created issue jupyterlab/jupyterlab#14494 to track the need for the test case.

@jtpio jtpio mentioned this issue May 9, 2023
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug jupyterlab Issues that belong to the jupyterlab repo
Projects
None yet
Milestone
7.0.x
Development

Successfully merging a pull request may close this issue.

Update to JupyterLab 4.0.0rc1 jtpio/notebook
3 participants
@jtpio @RRosio @andrii-i