-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4.0.0b1
and 4.0.0b2
#6838
Conversation
Looks like this piece of code is not hit on page reload: notebook/packages/notebook-extension/src/index.ts Lines 85 to 88 in f0ec5f3
Although the kernel logo using the same approach and shows up fine: notebook/packages/notebook-extension/src/index.ts Lines 180 to 182 in f0ec5f3
|
cc @fcollonval @brichet I see a few PRs related to the settings in the Maybe you know if they could be related to the issue mentioned above? |
@jtpio yes it's strange. |
@jtpio reverting the changes you mentioned at jupyterlab/jupyterlab#14195 (comment) seems that this does not fix it. Another thing that is strange, both widgets (title and checkpoint) are displayed if the related plugin activation do not depends on EDIT: |
Thanks @brichet for looking into it 👍
That's strange. At first glance I don't see why the |
Actually, the problem comes from another part of jupyterlab/jupyterlab#14195: Everything works fine if I avoid this part for |
Maybe it's a race condition, or the behavior is undefined depending on which plugin is activated first? |
Maybe we should track this in a separate issue in JupyterLab so it can be fixed for the next JupyterLab beta release? It looks like a breaking change which currently blocks the update of Notebook 7. |
I opened jupyterlab/jupyterlab#14366 to track this. |
There is a workaround for this update, waiting for it to be fixed in the next release of JupyterLab: |
e0ff7fc
to
897aa6c
Compare
Beta 2 seems to be fixing the settings issue mentioned above 👍 Now the button to add a new cell at the end of the notebook needs to be fixed. For reference it was added in jupyterlab/jupyterlab#14109 |
Might just try to disable it for now to be able to finish this update. |
4.0.0b1
and 4.0.0b2
bot please update playwright snapshots |
bot please update playwright snapshots |
Looks like we might hit jupyterlab/jupyterlab#14385 as well. |
Opened #6852 to track adding back the "Click to add a cell" button. It was causing issues on CI with the reference snapshots on Firefox. |
Update to https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b1 and https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b2
@jupyterlab
,@lumino
packages