Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Mermaid Support #6902

Closed
Tracked by #7087
startakovsky opened this issue Jun 6, 2023 · 6 comments · Fixed by #7096
Closed
Tracked by #7087

Feature Request: Mermaid Support #6902

startakovsky opened this issue Jun 6, 2023 · 6 comments · Fixed by #7096

Comments

@startakovsky
Copy link

This issue was never addressed or triaged. I am curious whether there is an opportunity to work on this feature. It would be empowering to be able to nimbly modify mermaid diagrams within the markdown cells.

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Jun 6, 2023
@startakovsky
Copy link
Author

Here is a long list of mermaid integrations, and it renders in GitHub markdown for example.... something like

sequenceDiagram
    Alice->>John: Hello John, how are you?
    John-->>Alice: Great!
    Alice-)John: See you later!
Loading

@jtpio
Copy link
Member

jtpio commented Jun 6, 2023

Thanks @startakovsky.

Note there is a PR in JupyterLab that will add support for Mermaid: jupyterlab/jupyterlab#14102

When it gets merged (likely soon for JupyterLab 4.1), then it should work in Notebook 7 out of the box as well.

@jtpio jtpio added this to the 7.1 milestone Jun 6, 2023
@startakovsky
Copy link
Author

Yeah!!! Awesome! I will hang tight.

@startakovsky
Copy link
Author

Actually, since that PR has been opened nearly 6 months ago, I will be using this frontend extension to handle rendering mermaid markdown.
image

@RRosio RRosio added status:Blocked and removed status:Needs Triage Applied to issues that need triage labels Jun 13, 2023
@RRosio
Copy link
Collaborator

RRosio commented Jun 13, 2023

Once @bollwyvl's PR in Jupyterlab gets merged in, this will go into Notebook 7.

@jtpio
Copy link
Member

jtpio commented Oct 27, 2023

FYI @startakovsky this is now available in the 7.1.0a0 pre-release: https://github.com/jupyter/notebook/releases/tag/v7.1.0a0

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants