Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow raises-exception to continue #2549

Merged
merged 2 commits into from Jun 9, 2017
Merged

allow raises-exception to continue #2549

merged 2 commits into from Jun 9, 2017

Conversation

mscuthbert
Copy link
Contributor

@mscuthbert mscuthbert commented Jun 6, 2017 •
edited

Fixes #2516 — allows for code execution to continue if a tag “raises-exception” or “nbval-raises-exception” is encountered

@takluyver
Copy link
Member

This looks OK, but let's not check for the nbval- version of the tag here; leave that to be specific to nbval. We should add the generic one to nbval, though.

mscuthbert added a commit to mscuthbert/nbval that referenced this pull request Jun 8, 2017
@mscuthbert
Allow tag of "raises-exception" without prefix
2040c9f 
Next version of notebook will continue to run through cells that raise error if the tag "raises-exception" is included in the metadata tag.  This edit allows this feature from notebook to be included in nbval.  See jupyter/notebook#2549
@mscuthbert mscuthbert changed the title allow raises-exception or nbval-raises-exception to continue allow raises-exception to continue Jun 8, 2017
@mscuthbert mscuthbert mentioned this pull request Jun 8, 2017
Merged
@mscuthbert
Copy link
Contributor Author

Done -- and patch to nbval is also being reviewed as computationalmodelling/nbval#64

@takluyver takluyver added this to the 5.1 milestone Jun 9, 2017
@takluyver
Copy link
Member

Thanks!

@takluyver takluyver merged commit 3140085 into jupyter:master Jun 9, 2017
@blink1073 blink1073 mentioned this pull request Jun 9, 2017
Closed
@takluyver takluyver mentioned this pull request Aug 25, 2017
Open
@mpacer mpacer mentioned this pull request Sep 1, 2017
Closed
@vidartf vidartf mentioned this pull request Jan 30, 2018
Open
@vidartf vidartf mentioned this pull request Feb 27, 2018
Closed
@takluyver takluyver mentioned this pull request Mar 1, 2018
Closed
3 tasks
@vidartf vidartf mentioned this pull request May 2, 2018
Closed
@dlukes dlukes mentioned this pull request Nov 6, 2018
Open
@takluyver takluyver mentioned this pull request Nov 7, 2018
Closed
@mgeier mgeier mentioned this pull request Nov 13, 2018
Open
@blink1073 blink1073 mentioned this pull request May 28, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Use tag to set stop_on_error for CodeCell (Enhancement)
2 participants
@mscuthbert @takluyver