Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow raises-exception to continue #2412

Closed
blink1073 opened this issue Jun 9, 2017 · 5 comments · Fixed by #6424
Closed

Allow raises-exception to continue #2412

blink1073 opened this issue Jun 9, 2017 · 5 comments · Fixed by #6424
Assignees
Labels
pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Feature Parity
Milestone

Comments

@blink1073
Copy link
Member

blink1073 commented Jun 9, 2017

cf jupyter/notebook#2549. Allows for code execution to continue if a tag “raises-exception” is encountered.

@mgeier
Copy link
Contributor

mgeier commented Nov 13, 2018

👍 This would be a great feature, but please don't make the same mistake that notebook (jupyter/notebook#4198) and nbconvert (jupyter/nbconvert#730) made:

If an exception is raised in a cell tagged with raises-exception, the execution of the following cells should continue. So far, so obvious. However, if such a cell does not raise an exception, this should itself be an error (and probably itself raise an exception show an error dialog(?) mentioning the raises-exception tag) and stop further cells from executing.

@paugier
Copy link

paugier commented May 23, 2019

"raises-exception" is really a must-have feature for pedagogical notebooks. It would really be good to be able to use this tag in jupyter-lab.

@blink1073
Copy link
Member Author

Thanks for the prompt, @paugier, I'll take this one for 1.0.

@blink1073 blink1073 modified the milestones: Future, 1.0 May 23, 2019
@blink1073
Copy link
Member Author

I am going to implement the same behavior as notebook. If it changes there, we will follow suit.

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Feature Parity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants