Only check links when build is trigger by Travis Cron job#3493
Merged
takluyver merged 2 commits intojupyter:masterfrom Apr 4, 2018
Merged
Only check links when build is trigger by Travis Cron job#3493takluyver merged 2 commits intojupyter:masterfrom
takluyver merged 2 commits intojupyter:masterfrom
Conversation
Member
|
Thanks @ashleytqy ! 🍪 I've set up the cron job on Travis. |
Member
|
And here's the first cron job running: https://travis-ci.org/jupyter/notebook/builds/362050037 |
Member
|
And the link check happens in the cron job, so this is working :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3292
This line
make -C docs/ linkcheck || EXIT_STATUS=$?;that does the link checking will only run if the build is triggered by a cron job.Let me know if there are any changes to be made!