jQuery attribute selector value MUST be surrounded by quotes #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Apr 11, 2018
| @@ -209,7 +209,7 @@ requirejs([ | |||
|
|
|||
| // load tab if url hash | |||
| if (window.location.hash) { | |||
| $("#tabs").find("a[href=" + window.location.hash + "]").click(); | |||
There was a problem hiding this comment.
Thanks! It looks like it's possible to use 'single quotes' (jQuery docs) rather than escaping double quotes, which would be a bit easier to read, IMO. It's not a big deal, though.
There was a problem hiding this comment.
Good point, much more readable. Fixed!
elgalu
force-pushed
the
attr-selector-surr-quot
branch
from
5d328b3
to
3d82761
Compare
elgalu
force-pushed
the
attr-selector-surr-quot
branch
from
3d82761
to
27710b9
Compare
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same problem as ipython/ipyparallel#321