Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery attribute selector value MUST be surrounded by quotes #3527

Merged
merged 1 commit into from Apr 12, 2018
Merged

jQuery attribute selector value MUST be surrounded by quotes #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion notebook/static/tree/js/main.js
View file
Open in desktop
Expand Up @@ -209,7 +209,7 @@ requirejs([

// load tab if url hash
if (window.location.hash) {
$("#tabs").find("a[href=" + window.location.hash + "]").click();
Copy link
Member

@takluyver takluyver Apr 11, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like it's possible to use 'single quotes' (jQuery docs) rather than escaping double quotes, which would be a bit easier to read, IMO. It's not a big deal, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, much more readable. Fixed!

$("#tabs").find("a[href='" + window.location.hash + "']").click();
}

shutdownbutton.activate();
Expand Down