Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade marked #3686

Merged
merged 3 commits into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@gnestor
Copy link
Contributor

gnestor commented Jun 14, 2018

marked 0.4 introduces support for checkboxes:

image

Closes #1578 (comment)

@gnestor gnestor referenced this pull request Jun 14, 2018

Merged

Upgrade marked #4728

@minrk minrk added this to the 5.6 milestone Jun 15, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jun 15, 2018

It looks like this has slightly altered some markdown rendering, breaking a test.

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Jun 15, 2018

The failure is a Selenium test in notebook/tests/selenium/test_markdown.py

@takluyver takluyver merged commit 0179bb4 into jupyter:master Jun 16, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 1918856...2ca3684
Details
codecov/project 74.09% remains the same compared to 1918856
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor deleted the gnestor:upgrade-marked branch Jun 18, 2018

colinjbrown added a commit to colinjbrown/dfkernel that referenced this pull request Jul 16, 2018

Pull in changes from jupyter/notebook#3686
These are changes to the markdown test as dependencies shifted to the new marked 0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.