Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary message issue when configured for gateway forwarding #4576

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix binary message issue when configured for gateway forwarding #4576

merged 1 commit into from
Jun 25, 2019

Conversation

SolarisYan
Copy link
Contributor

If message is bytes, we should set binary=True
This is from PR jupyter/nb2kg#33

If message is bytes, we should set binary=True
@kevin-bates
Copy link
Member

@SolarisYan - I just noticed the PR title isn't very specific - there are multiple handlers.py files within notebook. In order to help the maintainers (and general readers), would you mind updating the title to something along the lines of: Fix binary message issue when configured for gateway forwarding

@SolarisYan
Copy link
Contributor Author

@kevin-bates Sure, thanks for your reminding

@SolarisYan SolarisYan changed the title Update handlers.py Fix binary message issue when configured for gateway forwarding Apr 21, 2019
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you!

@lresende lresende mentioned this pull request Jun 20, 2019
@jasongrout jasongrout added this to the 6.0 milestone Jun 21, 2019
@lresende lresende merged commit 83f591b into jupyter:master Jun 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants