Port NB2KG PRs to Gateway #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Setting milestone 6 at @lresende's request |
The connect and request timeout defaults have been updated from 20 to 60 seconds and a default value of 40 has been added for KERNEL_LAUNCH_TIMEOUT. The code ensures that KERNEL_LAUNCH_TIMEOUT is in the env and that the value of the request timeout is at least 2 greather than KERNEL_LAUNCH_TIMEOUT. This PR is port of the NB2KG PRs 35 and 38.
kevin-bates
force-pushed
the
nb2kg-pr-port
branch
from
0bf886d
to
eb4285e
Compare
lresende
approved these changes
Jun 25, 2019
48 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the winds of a Notebook 6.0 release are blowing, we need to get some of the recent fixes in NB2KG into the Gateway module for Notebook since 6.0 marks the first release in which the extension is embedded in Notebook.
The ported changes are the following:
Once Notebook 6.0 is available, we will move NB2KG into maintenance mode.
cc: @Zsailer - we'll want this PR included in the list at jupyter-server/jupyter_server#53. Thanks!